Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix time units validation (issue #705) #706

Merged
merged 1 commit into from
May 10, 2020
Merged

fix time units validation (issue #705) #706

merged 1 commit into from
May 10, 2020

Conversation

lucasflomuller
Copy link
Contributor

fix issue #705.

It was a simple problem, this is my first contribution so if I didn't follow some standard I'm sorry.

gitbrent
gitbrent requested changes Apr 10, 2020
View reviewed changes
Copy link
Owner

@gitbrent gitbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the two generated dist files (es and cjs), otherwise, looks good.

@gitbrent gitbrent self-assigned this Apr 10, 2020
@gitbrent gitbrent added this to the 3.2.0 milestone Apr 10, 2020
@gitbrent gitbrent linked an issue Apr 10, 2020 that may be closed by this pull request
catAxisTime options are not recognized #705
Closed
@lucasflomuller lucasflomuller requested a review from gitbrent April 13, 2020 12:44
@gitbrent gitbrent merged commit b7fdc60 into gitbrent:master May 10, 2020
@gitbrent
Copy link
Owner

Thanks @lucasflomuller !

gitbrent added a commit that referenced this pull request May 10, 2020
@gitbrent
Added Pull #706
cb20fa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitbrent gitbrent gitbrent approved these changes

Assignees

@gitbrent gitbrent

Labels
issue:bug
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

catAxisTime options are not recognized
2 participants
@lucasflomuller @gitbrent