Create temporary cache files in Dir.tmpdir #459

olleolleolle · 2016-12-02T20:57:35Z

This PR is a compatibility bugfix for an issue on Windows.

See #458

Question: Does it work for you, @Arcanemagus? (Update: no, but that's another issue.)

Additional note: A directory such as C:\tmp must exist on the Windows machine for this to work right.

olleolleolle · 2016-12-02T21:27:04Z

(There were linting problems due to changed rules, rebased against new master.)

Arcanemagus · 2016-12-05T21:54:01Z

I'll see if I can build it locally to test.

Arcanemagus · 2016-12-05T22:11:39Z

Seems to still be failing in the same place:

C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:711:in `initialize': No such file or directory @ rb_sysopen - /tmp/github-changelog-logger.log (Errno::ENOENT)
        from C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:711:in `open'
        from C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:711:in `create_logfile'
        from C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:705:in `rescue in open_logfile'
        from C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:702:in `open_logfile'
        from C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:695:in `set_dev'
        from C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:635:in `initialize'
        from C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:353:in `new'
        from C:/Ruby23-x64/lib/ruby/2.3.0/logger.rb:353:in `initialize'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:52:in `new'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:52:in `init_cache'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:36:in `initialize'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/generator/generator.rb:24:in `new'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/generator/generator.rb:24:in `initialize'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator.rb:28:in `new'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator.rb:28:in `initialize'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/bin/github_changelog_generator:5:in `new'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/bin/github_changelog_generator:5:in `<top (required)>'
        from C:/Ruby23-x64/bin/github_changelog_generator:22:in `load'
        from C:/Ruby23-x64/bin/github_changelog_generator:22:in `<main>'

Note that bundle exec rake checks does show a failure, but I'm not sure if it's related:

PS C:\Users\Landon Abney\Documents\GitHub\github-changelog-generator> bundle exec rake checks
Running RuboCop...
Inspecting 27 files
...........................

27 files inspected, no offenses detected
C:/Ruby23-x64/bin/ruby.exe -I'C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/rspec-core-3.5.4/lib';'C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/rspec-support-3.5.0/lib' 'C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/rspec-core-3.5.4/exe/rspec' --pattern 'spec/**{,/*/**}/*_spec.rb'
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 13708
.Error: wrong GitHub token                                              PR: 1/1
....................Can't detect user and name from first parameter: 'blah' -> exit'
..........................................................

Failures:

  1) GitHubChangelogGenerator::OctoFetcher#check_github_response when raises Octokit::Forbidden sleeps and retries and then aborts
     Failure/Error: Helper.log.warn @client.rate_limit

     Faraday::SSLError:
       SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed
     # ./lib/github_changelog_generator/octo_fetcher.rb:332:in `block in retry_callback'
     # ./lib/github_changelog_generator/octo_fetcher.rb:297:in `check_github_response'
     # ./spec/unit/octo_fetcher_spec.rb:35:in `block (4 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # Octokit::Forbidden:
     #   Octokit::Forbidden
     #   ./spec/unit/octo_fetcher_spec.rb:35:in `block (5 levels) in <top (required)>'

Finished in 11.58 seconds (files took 4.14 seconds to load)
137 examples, 1 failure

Failed examples:

rspec ./spec/unit/octo_fetcher_spec.rb:30 # GitHubChangelogGenerator::OctoFetcher#check_github_response when raises Octokit::Forbidden sleeps and retries and then aborts

Randomized with seed 13708

[Coveralls] Outside the CI environment, not sending data.
Coverage report generated for RSpec to C:/Users/Landon Abney/Documents/GitHub/github-changelog-generator/coverage. 927 / 1352 LOC (68.57%) covered.
C:/Ruby23-x64/bin/ruby.exe -I'C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/rspec-core-3.5.4/lib';'C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/rspec-support-3.5.0/lib' 'C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/rspec-core-3.5.4/exe/rspec' --pattern 'spec/**{,/*/**}/*_spec.rb' failed

Something seems to be up though, since if I manually put the proper temp path in there it still gives that same path, trying to trace down whether options is screwing it up.

Arcanemagus · 2016-12-05T22:14:59Z

Okay, the options object coming into the OctoFetcher.initialize is where the improper path is coming from, tracing down where that is getting the wrong value.

My .github_changelog_generator files are all variants of this, so it's not from them:

unreleased=true
future-release=v0.12.0
exclude_labels=duplicate,question,invalid,wontfix,Duplicate,Question,Invalid,Wontfix,External

olleolleolle · 2016-12-05T22:19:01Z

@Arcanemagus https://github.com/skywinder/github-changelog-generator/blob/eaf7cd9447541df5730742b0b41412d58606f56b/lib/github_changelog_generator/parser.rb#L222 Here! Thanks for testing it!

Arcanemagus · 2016-12-05T22:20:06Z

I literally just found that and looked over here to post that only to see your comment appear 😛!

olleolleolle · 2016-12-05T22:21:49Z

@Arcanemagus If you change those to the starting value nil, what does our program do then?

        cache_file: nil,
        cache_log: nil

Arcanemagus · 2016-12-05T22:24:44Z

I hit the following then:

C:/Ruby23-x64/lib/ruby/2.3.0/net/http.rb:933:in `connect_nonblock': SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed (Faraday::SSLError)
        from C:/Ruby23-x64/lib/ruby/2.3.0/net/http.rb:933:in `connect'
        from C:/Ruby23-x64/lib/ruby/2.3.0/net/http.rb:863:in `do_start'
        from C:/Ruby23-x64/lib/ruby/2.3.0/net/http.rb:852:in `start'
        from C:/Ruby23-x64/lib/ruby/2.3.0/net/http.rb:1398:in `request'
        from C:/Ruby23-x64/lib/ruby/2.3.0/net/http.rb:1156:in `get'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-0.10.0/lib/faraday/adapter/net_http.rb:81:in `perform_request'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-0.10.0/lib/faraday/adapter/net_http.rb:41:in `block in call'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-0.10.0/lib/faraday/adapter/net_http.rb:88:in `with_net_http_connection'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-0.10.0/lib/faraday/adapter/net_http.rb:33:in `call'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-0.10.0/lib/faraday/response.rb:8:in `call'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-http-cache-2.0.0/lib/faraday/http_cache.rb:290:in `fetch'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-http-cache-2.0.0/lib/faraday/http_cache.rb:195:in `process'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-http-cache-2.0.0/lib/faraday/http_cache.rb:142:in `call!'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-http-cache-2.0.0/lib/faraday/http_cache.rb:115:in `call'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-0.10.0/lib/faraday/rack_builder.rb:139:in `build_response'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-0.10.0/lib/faraday/connection.rb:377:in `run_request'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/faraday-0.10.0/lib/faraday/connection.rb:140:in `get'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/sawyer-0.8.1/lib/sawyer/agent.rb:94:in `call'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/octokit-4.6.2/lib/octokit/connection.rb:154:in `request'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/octokit-4.6.2/lib/octokit/connection.rb:84:in `paginate'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/octokit-4.6.2/lib/octokit/client/repositories.rb:465:in `tags'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:79:in `block in calculate_pages'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:298:in `block in check_github_response'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/retriable-2.1.0/lib/retriable.rb:54:in `block in retriable'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/retriable-2.1.0/lib/retriable.rb:48:in `times'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/retriable-2.1.0/lib/retriable.rb:48:in `retriable'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:297:in `check_github_response'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:78:in `calculate_pages'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:97:in `github_fetch_tags'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:70:in `block in get_all_tags'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:298:in `block in check_github_response'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/retriable-2.1.0/lib/retriable.rb:54:in `block in retriable'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/retriable-2.1.0/lib/retriable.rb:48:in `times'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/retriable-2.1.0/lib/retriable.rb:48:in `retriable'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:297:in `check_github_response'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/octo_fetcher.rb:70:in `get_all_tags'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/generator/generator_tags.rb:9:in `fetch_and_filter_tags'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator/generator/generator_generation.rb:8:in `compound_changelog'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/lib/github_changelog_generator.rb:34:in `run'
        from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/github_changelog_generator-1.14.2/bin/github_changelog_generator:5:in `<top (required)>'
        from C:/Ruby23-x64/bin/github_changelog_generator:22:in `load'
        from C:/Ruby23-x64/bin/github_changelog_generator:22:in `<main>'

This does look related to the spec failure, want a new issue filed for that?

olleolleolle · 2016-12-05T22:27:00Z

@Arcanemagus No, this is not an issue with the program, my guess is it's that's a SSL certificates issue, related to your machine not having certificate authorities' certificate bundles available to it.

Here's a long article about it: http://mislav.net/2013/07/ruby-openssl/

Arcanemagus · 2016-12-05T22:48:44Z

I understand that it's an SSL error, my point (as a user) is that v1.13.2 works, and v1.14.0 (and up) doesn't due to that.

From what I've been finding around on the web the "solution" seems to all point to variants of http://stackoverflow.com/a/16134586/631338 which is a bit silly to expect all your users to have to go through.

olleolleolle · 2016-12-05T22:57:55Z

Right

Arcanemagus · 2016-12-05T23:08:38Z

lostisland/faraday#392 (comment) is exactly my point, this is on github_changelog_generator to ensure it has a working certificate store (since apparently Ruby can't use the system one?!?).

I'm assuming that's why github_api and several other gems are bundling the cacert.pem file with their project.

olleolleolle · 2016-12-05T23:16:46Z

I'm not saying you're wrong.

Commits like this:
piotrmurach/github@926cd06

...they put a lot of responsibility in the hands of the individual project: when a cert is un-trusted for some reason, the project's got to update their cert bundle. Example:
http://superuser.com/questions/605900/why-wont-os-x-trust-githubs-ssl-certificate

I'll mull on this.

olleolleolle · 2017-02-08T17:12:09Z

@Arcanemagus In order to solve one thing at a time, can we open a new Windows-labeled issue for the cacert.pem SSL cert idea?

olleolleolle · 2017-02-08T17:14:39Z

@Arcanemagus In order for the Issue to be owned by you, can you open it, and make links and such? (I don't run Windows.)

Arcanemagus · 2017-02-08T17:14:58Z

Already writing it 😉.

olleolleolle added the bug label Dec 2, 2016

olleolleolle changed the title ~~Temporary cache files created in Dir.tmpdir~~ Create temporary cache files in Dir.tmpdir Dec 2, 2016

olleolleolle force-pushed the fix/issue-with-tmp-dir branch from 1ec990d to d264fec Compare December 2, 2016 21:26

olleolleolle added the windows label Dec 2, 2016

olleolleolle added 3 commits December 6, 2016 00:08

OctoFetcher: http_cache options conditional

d8289b8

Locate cache directory using Dir.tmpdir

7e3655d

Cache files options can not have defaults

2012940

olleolleolle force-pushed the fix/issue-with-tmp-dir branch from 4b282bd to 2012940 Compare December 5, 2016 23:08

Arcanemagus mentioned this pull request Feb 4, 2017

v1.14.0 Fails with missing /tmp/ path on Windows #458

Closed

olleolleolle merged commit 8d74965 into github-changelog-generator:master Feb 8, 2017

olleolleolle deleted the fix/issue-with-tmp-dir branch February 8, 2017 17:14

Arcanemagus mentioned this pull request Feb 8, 2017

SSL Cert issue on Windows #475

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create temporary cache files in Dir.tmpdir #459

Create temporary cache files in Dir.tmpdir #459

olleolleolle commented Dec 2, 2016 •

edited

Loading

olleolleolle commented Dec 2, 2016

Arcanemagus commented Dec 5, 2016

Arcanemagus commented Dec 5, 2016

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016 •

edited

Loading

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016 •

edited

Loading

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016 •

edited

Loading

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016

olleolleolle commented Feb 8, 2017

olleolleolle commented Feb 8, 2017

Arcanemagus commented Feb 8, 2017

Create temporary cache files in Dir.tmpdir #459

Create temporary cache files in Dir.tmpdir #459

Conversation

olleolleolle commented Dec 2, 2016 • edited Loading

olleolleolle commented Dec 2, 2016

Arcanemagus commented Dec 5, 2016

Arcanemagus commented Dec 5, 2016

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016 • edited Loading

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016 • edited Loading

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016 • edited Loading

Arcanemagus commented Dec 5, 2016

olleolleolle commented Dec 5, 2016

olleolleolle commented Feb 8, 2017

olleolleolle commented Feb 8, 2017

Arcanemagus commented Feb 8, 2017

olleolleolle commented Dec 2, 2016 •

edited

Loading

olleolleolle commented Dec 5, 2016 •

edited

Loading

olleolleolle commented Dec 5, 2016 •

edited

Loading

olleolleolle commented Dec 5, 2016 •

edited

Loading