This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Aggregate pipeline scores #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a function in
aggregate-results.jswhich aggregates the test scores.It outputs a table depending on the scores of the tests in a runner, against the max score (if defined) and computes the weight of the entire assignment:
For example if two runners are weighted to have 1 point each and one fails, the total score at the end would be 50%.
However, if the two runners have two different max scores that are not equivalent to 100, the weight is still distributed:
One thing that needs to be addressed is the
max_scorefrom the io runner is not working properly. I will do some digging into this tomorrow to see why/how but the math behind this aggregate function should be working fine!