-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraphQL syntax highlighting to GFM code fences #2637
Comments
Is the file extension for GraphQL |
File extension is recommended to be |
Oh, great! (I had this impression because facebook/graphql is using I can open a pull request to add detection for GraphQL. Do you have a sample file I could use though? |
Is there a color from an official logo I could use for the language bar? |
#E535AB |
Hum, I'm getting ahead of myself. I don't think there are enough @arfon Could we only add support for GraphQL without a file extension (only for code snippets as it was the original request)? |
I'm most concerned at this point with syntax highlighting than I am with showing the percentage of We have many examples in the Relay universe that could benefit from this treatment. See “Proposed API” of this issue: facebook/relay#114 Another issue altogether is how to syntax highlight fragments of GraphQL found inside JS |
Even with wide proliferation of GraphQL the use of .graphql files will probably not be all that common. However GraphQL code blocks in markdown files will be. |
I've just closed a pull request asking for the same thing so I really don't want to make an exception here unless we can demonstrate more wide-scale usage of the syntax. @leebyron/@pchaigno - do you have any suggestions for finding more files that might contain |
.graphql appears to be the recommended file extension, per @leebyron: github-linguist/linguist#2637 (comment) We'll continue to support the abbreviated .gql extension.
Opening this issue to track the addition of GraphQL syntax highlighting to GFM.
Use the syntax highlighter from https://github.com/rmosolgo/language-graphql
Click here for an example of highlighted source.
The text was updated successfully, but these errors were encountered: