Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for licences if available #539

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Conversation

games647
Copy link
Contributor

@games647 games647 commented Oct 1, 2017

I checked if the links in the licenses are reachable with HTTPS (including if they have valid certificate). If they are I changed the url to use HTTPS, but kept the other ones to plain HTTP like: http://www.wtfpl.net/

@mlinksva
Copy link
Contributor

mlinksva commented Oct 1, 2017

@games647 good idea for the links in frontmatter, thanks. But I'd rather not change license texts at all. Could you update this to only change frontmatter links?

@games647
Copy link
Contributor Author

games647 commented Oct 1, 2017

But I'd rather not change license texts at all.

Should I then change the text of the unlicense too, because the original version contains only a HTTP link?

For more information, please refer to <https://unlicense.org>

vs

https://unlicense.org/UNLICENSE (without HTTPS)

@mlinksva
Copy link
Contributor

mlinksva commented Oct 1, 2017

@games647 yes and thank you!

I shouldn't have merged #520 -- I remember thinking the change was to the frontmatter, but obviously was only seeing what I thought I should see. 😳

@games647
Copy link
Contributor Author

games647 commented Oct 1, 2017

Done

@mlinksva
Copy link
Contributor

mlinksva commented Oct 1, 2017

Thanks again. Annoying that this is consistently happening in CI-run tests:

  • ./_site/existing/index.html
  • External link https://www.openbsd.org/policy.html failed: response code 0 means something's wrong.
    It's possible libcurl couldn't connect to the server or perhaps the request timed out.
    Sometimes, making too many requests at once also breaks things.
    Either way, the return message (if any) from the server is: SSL connect error

Though https://www.ssllabs.com/ssltest/analyze.html?d=www.openbsd.org obtains an 'A' rating.

I'll go ahead and merge as it seems that if there's a problem, it's with the test environment.

@mlinksva mlinksva merged commit c400867 into github:gh-pages Oct 1, 2017
@games647
Copy link
Contributor Author

games647 commented Oct 2, 2017

It could be because it's a let's encrypt certificate and the certificate storage on travis isn't up to date to support let's encrypt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants