Skip to content

Commit

Permalink
Address PR comments from @robertbrignull
Browse files Browse the repository at this point in the history
  • Loading branch information
edoardopirovano authored and Edoardo Pirovano committed Jul 26, 2021
1 parent e145aa4 commit 934fb86
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
run: .github/workflows/script/check-js.sh

check-node-modules:
runs-on: ubuntu-latest
runs-on: macos-latest

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/script/check-node-modules.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ if [ ! -z "$(git status --porcelain)" ]; then
>&2 echo "Failed: Repo should be clean before testing!"
exit 1
fi
sudo npm install --force -g npm@latest
# Reinstall modules and then clean to remove absolute paths
# Use 'npm ci' instead of 'npm install' as this is intended to be reproducible
npm ci
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/update-dependencies.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Update dependencies
on:
pull_request:
pull_request_target:
types: [opened, synchronize, reopened, labeled]

jobs:
update:
Expand Down Expand Up @@ -32,6 +33,9 @@ jobs:
git config --global user.email "[email protected]"
git config --global user.name "github-actions[bot]"
git add node_modules
git commit -am "Update checked-in dependencies"
git push
if ! git commit -am "Update checked-in dependencies" ; then
echo "No changes detected, skipping pushing..."
exit 0
fi
git push origin "$BRANCH"
6 changes: 1 addition & 5 deletions node_modules/.package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 934fb86

Please sign in to comment.