-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autobuild Go in analyze
if not already built
#1219
Conversation
781cafc
to
893add6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things.
I'll move this PR forward while Angela's on vacation. I'll start by addressing Andrew's review comments and adding a PR check to test the new behavior. |
3adbc27
to
962795a
Compare
This will enable us to test this behavior in PR checks. Also simplify and add some more detailed documentation.
Co-authored-by: Andrew Eisenberg <[email protected]>
`in` checks the indices of an array, not the values.
e86336e
to
8e0846c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A minor comment.
This change will run the autobuilder for Golang in the
analyze
step if:golang_extraction_reconciliation_enabled
is onThis change should be a no-op for now, as if a user has not provided manual build steps for Go, we treat Go as an interpreted language and the autobuilder will run even if users have not included the
autobuild
action.With some imminent changes where we will not treat Go as an interpreted language, we introduce this change to maintain backwards compatibility for users who may have removed the
autobuild
step and who have not provided manual build steps. In this case, we will still autobuild for them at the beginning of theanalyze
step.Merge / deployment checklist