Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit Swift autobuild runtime in PR check to 10 minutes #1507

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Limit Swift autobuild runtime in PR check to 10 minutes #1507

merged 1 commit into from
Jan 23, 2023

Conversation

henrymercer
Copy link
Contributor

There's a known issue that causes the Swift autobuilder to hang. By setting a timeout, we'll fail earlier and we can rerun the check earlier.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer
Limit Swift autobuild runtime to 10 minutes
b873a18 
There's a known issue that causes the Swift autobuilder to hang.  By
setting a timeout, we'll fail earlier and we can rerun the check
earlier.
@henrymercer henrymercer requested a review from a team as a code owner January 23, 2023 19:14
@adityasharad
Copy link
Contributor

github/codeql#11900 should fix the timeout but this is useful while we're still testing older versions.

angelapwen
angelapwen approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍

@henrymercer henrymercer enabled auto-merge January 23, 2023 19:18
@henrymercer henrymercer merged commit 824a20f into main Jan 23, 2023
@henrymercer henrymercer deleted the henrymercer/swift-autobuild-timeout branch January 23, 2023 20:16
@github-actions github-actions bot mentioned this pull request Jan 26, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

@adityasharad adityasharad adityasharad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrymercer @adityasharad @angelapwen