Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names to all pr-checks #713

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Add names to all pr-checks #713

merged 4 commits into from
Sep 1, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Aug 24, 2021

Small change to aid with debugging failing jobs. I tried to put the most important part of the name of each job first.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner August 24, 2021 23:26
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe JavaScript -> JS and CSharp -> C# for brevity. Other than that LGTM.

@adityasharad
Copy link
Contributor

...and we have to update our branch protection rules 😆

@aeisenberg aeisenberg force-pushed the aeisenberg/pr-check-names branch from 9fe2f7c to 88bc9ac Compare August 24, 2021 23:36
@aeisenberg
Copy link
Contributor Author

Maybe JavaScript -> JS and CSharp -> C# for brevity. Other than that LGTM.

Good call. Done.

@aeisenberg
Copy link
Contributor Author

...and we have to update our branch protection rules 😆

That's not a PR, though, is it?

@aeisenberg aeisenberg enabled auto-merge August 24, 2021 23:38
@aeisenberg
Copy link
Contributor Author

Odd...does not seem to be showing the new names.

@aeisenberg aeisenberg disabled auto-merge August 24, 2021 23:39
@aeisenberg aeisenberg force-pushed the aeisenberg/pr-check-names branch from 88bc9ac to 1785bbb Compare August 25, 2021 17:38
@aeisenberg aeisenberg enabled auto-merge August 25, 2021 17:39
@edoardopirovano
Copy link
Contributor

I think automerge won't work due to the checks changing name?

@adityasharad
Copy link
Contributor

Yes, we have to change the Required checks in the branch protection rules in this repo's Settings page, to match the new check names.

@aeisenberg aeisenberg closed this Sep 1, 2021
auto-merge was automatically disabled September 1, 2021 22:33

Pull request was closed

@aeisenberg aeisenberg reopened this Sep 1, 2021
@aeisenberg aeisenberg force-pushed the aeisenberg/pr-check-names branch from e567e17 to e22a6cd Compare September 1, 2021 22:34
@aeisenberg aeisenberg enabled auto-merge September 1, 2021 22:43
@aeisenberg
Copy link
Contributor Author

Going to need this PR to be force-pushed. It is getting confused because it is expecting all check names to pass, when they no longer exist.

@aeisenberg aeisenberg disabled auto-merge September 1, 2021 22:46
@aeisenberg aeisenberg merged commit 62ef9f5 into main Sep 1, 2021
@aeisenberg aeisenberg deleted the aeisenberg/pr-check-names branch September 1, 2021 22:47
@github-actions github-actions bot mentioned this pull request Sep 6, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants