-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report ML-powered query enablement in the init
status report
#907
Report ML-powered query enablement in the init
status report
#907
Conversation
We report this information in the `init` status report rather than the `analyze` status report so we can gather data about timeouts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor thing, otherwise looks good.
I believe you also need a PR such as https://github.com/github/hydro-schemas/pull/1845 to add the new field to the database and also a |
Thanks, these are in the works (see the internal tracking issue)! |
When multiple ML-powered JS packs are in scope (an unsupported scenario), the status report is "multiple".
Some platforms that ingest this status report charge based on the cardinality of the fields, so here we restrict the version strings we support to a fixed set.
Also be more explicit about which version strings are reportable in the code.
Adds information about whether ML-powered JS queries are enabled to the
init
status report. This will improve our observability by allowing us to compare metrics between runs with ML-powered JS queries on and off.Specifically, we add a
ml_powered_js_queries
field to theinit
status report that contains:We report this information in the
init
status report rather than theanalyze
status report so we can gather data about timeouts.Example status report:
Merge / deployment checklist