[Java] Add CompileTimeConstantExpr.getStringified method #8360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLLeitschuh
force-pushed
the
feat/JLL/compile_time_constant_getStringified
branch
3 times, most recently
from
8d8eb7c to
91efa4f
Compare
Removes CharacterLiteral from CompileTimeConstantExpr.getStringValue Resolves: - github#8325 (comment) - github#8325 (comment)
JLLeitschuh
force-pushed
the
feat/JLL/compile_time_constant_getStringified
branch
from
91efa4f to
2e8b5f7
Compare
JLLeitschuh
commented
Mar 8, 2022
smowton
reviewed
Mar 8, 2022
java/ql/lib/change-notes/2022-03-07-char-literal-in-compile-time-constant.md
Outdated
Show resolved
Hide resolved
Marcono1234
reviewed
Mar 8, 2022
java/ql/lib/change-notes/2022-03-07-char-literal-in-compile-time-constant.md
Outdated
Show resolved
Hide resolved
Marcono1234
reviewed
Mar 8, 2022
Co-authored-by: Chris Smowton <[email protected]>
JLLeitschuh
force-pushed
the
feat/JLL/compile_time_constant_getStringified
branch
from
afbe2ca to
363fff2
Compare
smowton
previously approved these changes
Mar 9, 2022
|
I'm done with this PR, anyone who's able/interested, feel free to merge it! 😄 |
atorralba
approved these changes
Mar 11, 2022
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Mar 11, 2022
|
Should've measured performance, is very bad at least on Geogebra. Revert: #8402 |
This was referenced Mar 11, 2022
smowton
added a commit
that referenced
this pull request
Mar 11, 2022
Java: Revert #8360, "Add CompileTimeConstantExpr.getStringified method"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes CharacterLiteral from CompileTimeConstantExpr.getStringValue
Resolves: