-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update add-ssh-key-to-ssh-agent documentation #1074
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
👋 @GuillaumeBAECHLER Thank you so much for opening a PR! Some of the updates in this PR are already being addressed in #1063. Would you mind removing the duplication? 💖 |
Hi @janiceilene ! Can't find any duplication in the linked PR, the files concerned are not the same. Btw, I find there are a lot of PRs for this topic now. So we can close this PR if you want to address all changes linked to ed25519 documentation in a single one. 😄 |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request @GuillaumeBAECHLER!
To come back to this:
Can't find any duplication in the linked PR, the files concerned are not the same. Btw, I find there are a lot of PRs for this topic now. So we can close this PR if you want to address all changes linked to ed25519 documentation in a single one. 😄
You're right, there are quite a few similar PRs 😅 I'm working my way through them in reverse chronological order. Yours is one of the first, so I'll merge this and close any later duplicates 🎉
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
* added a note about the plans * Update cloud/service-settings/customize-configuration.md Co-authored-by: Lukas Bernert <[email protected]> Co-authored-by: Lukas Bernert <[email protected]> Co-authored-by: Lana Brindley <[email protected]>
Why:
Update the add-ssh-key-to-ssh-agent documentation with the new key generation algorithm used in ssh key creation step (ed25519)
What's being changed:
Replaced
id_rsa
withid_ed25519
in :Check off the following: