Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain critical blocking feature that causes tremendous misunderstan… #1092

Closed
wants to merge 2 commits into from
Closed

Explain critical blocking feature that causes tremendous misunderstan… #1092

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a3a87d
Explain critical blocking feature that causes tremendous misunderstan…
jidanni Nov 5, 2020
d12783f
Merge branch 'main' into patch-1
megbird Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ithub/building-a-strong-community/blocking-a-user-from-your-personal-account.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ In repositories you own, blocked users also cannot:
- Comment on issues, pull requests, or commits
- Add or edit wiki pages

(Keep in mind users you block will not receive email notifications of
comments you make, even if [@mentioning](/articles/basic-writing-and-formatting-syntax/#mentioning-people-and-teams) them directly.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful clarification ✨ but it seems like it would be more beneficial in one of the lists that already exist, just to keep content all in one place. I suggest making it a bullet point in the "After you've blocked a user, they cannot:" list, close to the related information 😄

After you've blocked a user, they cannot:

  • Send you any notifications, including by @mentioning your username
  • Receive any notifications sent by you, including comments @mentioning their username

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

＠megbird those are all great changes. I would just wait to see what direction @brentjo and @benbalter want to take this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @jidanni We have a process to ensure that pull requests are reviewed as quickly as we can, directly at-mentioning individuals will not get your pull request reviewed any more quickly and can actually slow the response due to people being distracted by notification noise.

@brentjo and @benbalter are not maintainers in this repository. You can add the changes @megbird suggested, as a maintainer of this repo, if you'd like to see an update to the docs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janiceilene , I would love to add them. But whatever I press seems to mess things up. Perhaps you folks can add them for me. Thanks.

### Blocking a user in your account settings

{% data reusables.user_settings.access_settings %}
Expand Down