-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify GH password requirements #1395
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@hongshaoyang Thanks so much for opening a PR! I'll get this triaged for review 🌟 |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
@janiceilene any updates on this PR? |
@hongshaoyang Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your change, @hongshaoyang! We really appreciate all the community contributions to help improve our docs 😊
I'll get this merged shortly!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
thanks @shati-patel |
Why:
Closes #1396 .
What's being changed:
The password requirements are missing the phrase "at least". Without this phrase, it seems like the password requirements must be exactly eight or 16 characters long.
Check off the following: