Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds clarity to PR Template #17859

Closed
wants to merge 10 commits into from
Closed

Adds clarity to PR Template #17859

wants to merge 10 commits into from

Conversation

thispsj
Copy link
Contributor

@thispsj thispsj commented May 15, 2022

Why:

Closes #17811

What's being changed:

Nothing just the PR Template. All changes have been already highlighted in the above linked issue.

Check off the following:

  • I have reviewed my changes in staging.
  • For content changes, I have completed the self-review checklist.

* Fixes links in comments.
* Makes wordings more clear.
@thispsj thispsj requested a review from a team as a code owner May 15, 2022 06:39
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 15, 2022
@gracepark gracepark requested review from a team and removed request for a team May 16, 2022 18:49
@steveward steveward added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 18, 2022
@janiceilene
Copy link
Contributor

Thanks so much for opening an issue and PR for this bug @thispsj! I'll get this triaged for the team to look at ✨

@thispsj
Copy link
Contributor Author

thispsj commented May 25, 2022

@janiceilene most probably that was a saved reply, but the credit of opening the issue goes to @janbrasna.

@cmwilson21
Copy link
Contributor

@thispsj Thank you for bringing this to our attention. 👀 After further inspection, the team has decided to update other parts of the template as well. I'll go ahead and close this PR as we will update it internally.

Thanks again for your passion to improve the docs! ✨

@cmwilson21 cmwilson21 closed this Jun 3, 2022
@surajmasram

This comment was marked as spam.

@thispsj thispsj deleted the fix-pr-template branch June 4, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR template referencing things not present
5 participants