Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cover triage level permissions for labels #1938

Merged
merged 12 commits into from
Jan 14, 2021
Merged

cover triage level permissions for labels #1938

merged 12 commits into from
Jan 14, 2021

Conversation

HonkingGoose
Copy link
Contributor

@HonkingGoose HonkingGoose commented Dec 9, 2020

Why:

Closes #1693.

What's being changed:

Explain that users with triage level permissions can apply/dismiss existing labels.

Update permissions table to also use the word "dismiss" to make clear that triage members can apply/dismiss existing labels.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@janiceilene
Copy link
Contributor

@HonkingGoose Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Dec 9, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 17, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 17, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 12, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 12, 2021
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HonkingGoose - Many thanks for raising this and making the change. Apologies for the delay getting this reviewed and merged.

We really appreciate your help with GitHub documentation. Thanks again. 👍

@hubwriter hubwriter merged commit fe00a6e into github:main Jan 14, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Managing labels" topic doesn't mention triage permissions
3 participants