Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update about-github-packages.md #2071

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Update about-github-packages.md #2071

merged 4 commits into from
Jan 14, 2021

Conversation

verhas
Copy link
Contributor

@verhas verhas commented Dec 14, 2020

Why:

The sentence makes no sense.

What's being changed:

One sentence in the documentation.

Check off the following:

  • [x ] All of the tests are passing. this is a documentation change
  • [x ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • [x ] For content changes, I have reviewed the localization checklist
  • [x ] For content changes, I have reviewed the Content style guide for GitHub Docs.

@welcome
Copy link

welcome bot commented Dec 14, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@verhas Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team labels Dec 14, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 22, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 22, 2020
@janiceilene
Copy link
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 30, 2020
@verhas
Copy link
Contributor Author

verhas commented Jan 3, 2021

What is the reason to ask for PRs if you both do not attend to it and the same time have automation that closes the request?

Should I bother to suggest fix for anything when a simple thing, like this, fixing a sentence in a documentation gets stale?

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Jan 3, 2021
@janiceilene
Copy link
Contributor

Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions and got quite backed up between the US Thanksgiving holiday, GitHub Universe, and our team taking some time off during the December holidays.

This PR has been triaged to the appropriate team and they'll take a look as soon as they can.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 13, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 14, 2021
runleonarun
runleonarun approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@verhas Thanks for your fix and your patience!

@runleonarun runleonarun added the ready to merge This pull request is ready to merge label Jan 14, 2021
@janiceilene janiceilene merged commit 8dc219c into github:main Jan 14, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@snyk-bot snyk-bot mentioned this pull request Dec 6, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 28, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team packages This issue or pull request should be reviewed by the docs packages team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@verhas @janiceilene @runleonarun