Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing-custom-queries.md #26278

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Update testing-custom-queries.md #26278

merged 2 commits into from
Jun 30, 2023

Conversation

nicholas-keers
Copy link
Contributor

@nicholas-keers nicholas-keers commented Jun 27, 2023

The Java example code block was empty with the code displayed inline below it, I have removed whitespace to fix it as per the bottom image

Why:

Closes: #26277

What's being changed (if available, include any code snippets, screenshots, or gifs):

2023-06-27 13 07 47 docs github.com e925902cb69c

Changing this to put the Java code into the code-block correctly, will also fix other parts below it as the tags were spilling over.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

The Java example code block was empty with the code displayed inline below it, I have removed whitespace to fix it
@welcome
Copy link

welcome bot commented Jun 27, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
code-security/codeql-cli/using-the-codeql-cli/testing-custom-queries.md fpt
ghec
ghes@ 3.9 3.8 3.7
fpt
ghec
ghes@ 3.9 3.8 3.7

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@nicholas-keers Thank you for opening a PR and linking it to your issue! ✨

Also, welcome to the community! I'll get this triaged for review! ⚡

In the meantime, if you'd like to find other ways to contribute, check out our help wanted section to find open issues you can work on. 👍

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team codeql Content related to CodeQL code security Content related to code security waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 29, 2023
@subatoi
Copy link
Contributor

subatoi commented Jun 30, 2023

@nicholas-keers Many thanks for spotting this. I changed the indentation such that the code box is part of numbered list, as intended, rather than rendered below it and independently of it. I've also noted where we need to change that in other places on this same page:

Screenshot 2023-06-30 at 09 03 52

Many thanks for your interest in helping us to improve our docs! ✨

@subatoi subatoi enabled auto-merge June 30, 2023 10:25
@subatoi subatoi added this pull request to the merge queue Jun 30, 2023
Merged via the queue into github:main with commit 7fc7867 Jun 30, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code security Content related to code security codeql Content related to CodeQL content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving the formatting on the Testing custom queries (CodeQL) page
3 participants