Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo sync #36637

Merged
merged 1 commit into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/codespace-review-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ jobs:
fi

# https://stackoverflow.com/a/70716837
# This might not need `| sed 's/"/\\"/g'`
matrix=$(echo "$branches" | jq -scR 'split("\n") | map(select(. != ""))' | sed 's/"/\\"/g')
matrix=$(echo "$branches" | jq -scR 'split("\n") | map(select(. != ""))')
echo "- Matrix: $matrix"
echo "matrix=$matrix" >> $GITHUB_OUTPUT

Expand All @@ -76,14 +75,16 @@ jobs:
matrix:
value: ${{ fromJSON(needs.codespace-review-check-find.outputs.matrix) }}
runs-on: ubuntu-latest
if: ${{ github.repository == 'github/docs-internal' }}
if: ${{ github.repository == 'github/docs-internal' && needs.codespace-review-check-find.outputs.matrix }}
env:
repo: github/docs-internal
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: Find the pull request
id: findPr
env:
GH_TOKEN: ${{ secrets.DOCS_BOT_PAT_CODESPACE }}
run: |
echo "Looking up pull request"
echo "- Branch: ${{ matrix.value }}"
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/codespace-review-up.yml
Original file line number Diff line number Diff line change
Expand Up @@ -214,10 +214,6 @@ jobs:
After 4 hours, you can reactivate your codespace by applying the https://github.com/${{ env.REPO }}/labels/extend-codespace label to the pull request.
If the label is already applied, you can remove and reapply the label to reactivate your codespace.

#### Maximum of 100 _active_ codespaces per user

Your codespace may be deleted if the limit is reached.

<details><summary>Table of review links</summary>

${{ steps.changes.outputs.changesTable && 'The table shows the files in the `content` directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the `data` directory are not included in this table.' || '' }}
Expand Down