-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OID for hrSWRun #3970
Update OID for hrSWRun #3970
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@goldstar611 Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm Not Sure If I Did Anything Worthwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few changes based on @b4mboo's suggestions, let me know if you have any questions 😄
Co-authored-by: Meg Bird <[email protected]>
Co-authored-by: Meg Bird <[email protected]>
The suggested changes look good and were accepted and committed. I removed the leading dots from the rest of the OIDs for consistency since there's nothing special about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect! we'll get this merge in ASAP, thank you so much for contributing ❤️
Hm, I'm missing an update branch button 🙃 I'm going to close this, then reopen it to see if that helps! |
I unchecked the "allow edits for maintainers" checkbox shortly after "alexander-creator306 (a new user on GitHub.com) "reviewed" my pr in an attempt to prevent any hijacking. I've re-checked that box in case it's not letting you do your thing. |
@goldstar611 Thanks for that! It's working now and I'll get it merged once tests are passing 💚 |
https://tools.ietf.org/html/rfc2790
Why:
The OID for hrSWRun was suspicious looking because it started with
1.1
while all other OIDs started with.1
. Upon further investigation withsnmpget
there are no published processes at neither1.1.3.6.1.2.1.25.41
nor.1.3.6.1.2.1.25.41
and referring to RFC 2790 we can see it should probably be.25.4
What's being changed:
hrSwRun OID at https://docs.github.com/en/[email protected]/admin/enterprise-management/monitoring-using-snmp
Check off the following: