Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OID for hrSWRun #3970

Merged
merged 6 commits into from
Mar 5, 2021
Merged

Update OID for hrSWRun #3970

merged 6 commits into from
Mar 5, 2021

Conversation

goldstar611
Copy link
Contributor

@goldstar611 goldstar611 commented Feb 24, 2021

https://tools.ietf.org/html/rfc2790

Why:

The OID for hrSWRun was suspicious looking because it started with 1.1 while all other OIDs started with .1. Upon further investigation with snmpget there are no published processes at neither 1.1.3.6.1.2.1.25.41 nor .1.3.6.1.2.1.25.41 and referring to RFC 2790 we can see it should probably be .25.4

   This revision published as RFC2790."

      REVISION "9910202200Z"    -- 20 October, 1999
      DESCRIPTION
          "The original version of this MIB, published as
          RFC1514."
      ::= { hrMIBAdminInfo 1 }

   host     OBJECT IDENTIFIER ::= { mib-2 25 }

   hrSystem        OBJECT IDENTIFIER ::= { host 1 }
   hrStorage       OBJECT IDENTIFIER ::= { host 2 }
   hrDevice        OBJECT IDENTIFIER ::= { host 3 }
   hrSWRun         OBJECT IDENTIFIER ::= { host 4 }

What's being changed:

hrSwRun OID at https://docs.github.com/en/[email protected]/admin/enterprise-management/monitoring-using-snmp

Check off the following:

@welcome
Copy link

welcome bot commented Feb 24, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise labels Feb 25, 2021
@janiceilene
Copy link
Contributor

@goldstar611 Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link

@Alexander-creator306 Alexander-creator306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Not Sure If I Did Anything Worthwhile.

@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 26, 2021
Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few changes based on @b4mboo's suggestions, let me know if you have any questions 😄

@goldstar611
Copy link
Contributor Author

I made a few changes based on @b4mboo's suggestions, let me know if you have any questions 😄

The suggested changes look good and were accepted and committed. I removed the leading dots from the rest of the OIDs for consistency since there's nothing special about the hrSWRun table and I couldn't find and RFCs that say the leading dot is absolutely necessary.

Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! we'll get this merge in ASAP, thank you so much for contributing ❤️

@megbird megbird added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 4, 2021
@janiceilene
Copy link
Contributor

Hm, I'm missing an update branch button 🙃 I'm going to close this, then reopen it to see if that helps!

@janiceilene janiceilene closed this Mar 5, 2021
@janiceilene janiceilene reopened this Mar 5, 2021
@goldstar611
Copy link
Contributor Author

I unchecked the "allow edits for maintainers" checkbox shortly after "alexander-creator306 (a new user on GitHub.com) "reviewed" my pr in an attempt to prevent any hijacking. I've re-checked that box in case it's not letting you do your thing.

@janiceilene
Copy link
Contributor

@goldstar611 Thanks for that! It's working now and I'll get it merged once tests are passing 💚

@janiceilene janiceilene merged commit 9464d75 into github:main Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants