Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new topic: scapy #2652

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Add new topic: scapy #2652

merged 5 commits into from
Oct 4, 2021

Conversation

joesinghh
Copy link
Contributor

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/scapy or https://github.com/collections/scapy)
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Scapy has become very popular and it's a powerful interactive packet manipulation program, that's why I think this topic should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@guedou
Copy link

guedou commented Oct 2, 2021

Some information provided in this PR are incorrect. I will try to provide feedback ASAP.

@joesinghh
Copy link
Contributor Author

Some information provided in this PR are incorrect. I will try to provide feedback ASAP.

sure, let me know so I can fix them.

Copy link

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply these changes?

topics/scapy/index.md Outdated Show resolved Hide resolved
topics/scapy/index.md Outdated Show resolved Hide resolved
topics/scapy/index.md Outdated Show resolved Hide resolved
topics/scapy/index.md Outdated Show resolved Hide resolved
@joesinghh
Copy link
Contributor Author

Could you apply these changes?

Thanks for reviewing them, I have now made the required changes.

Copy link

@guedou guedou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK. Thanks!

Copy link
Contributor

@kenyonj kenyonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🍨 Thank you for your contribution! I'll merge this in as soon as CI is 🍏

(I'll make the suggested change)

topics/scapy/index.md Outdated Show resolved Hide resolved
@kenyonj kenyonj enabled auto-merge October 4, 2021 07:50
Copy link
Contributor

@kenyonj kenyonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are still CI issues. Specifically:

topics::scapy topic#test_0019_has at most one image with the right name, type, and dimensions [/home/runner/work/explore/explore/test/topics_test.rb:229]:
topic images should be 288px wide.
Expected: 288
  Actual: 595

@joesinghh
Copy link
Contributor Author

@kenyonj Thanks, I'll add a different image now.

auto-merge was automatically disabled October 4, 2021 09:35

Head branch was pushed to by a user without write access

@joesinghh joesinghh requested a review from kenyonj October 4, 2021 09:39
@joesinghh
Copy link
Contributor Author

@kenyonj can you merge it now :)
Thank you for reviewing.

@kenyonj kenyonj merged commit c0c7cf2 into github:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants