-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new topic: scapy #2652
Add new topic: scapy #2652
Conversation
Some information provided in this PR are incorrect. I will try to provide feedback ASAP. |
sure, let me know so I can fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you apply these changes?
Thanks for reviewing them, I have now made the required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks OK. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 🍨 Thank you for your contribution! I'll merge this in as soon as CI is 🍏
(I'll make the suggested change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are still CI issues. Specifically:
topics::scapy topic#test_0019_has at most one image with the right name, type, and dimensions [/home/runner/work/explore/explore/test/topics_test.rb:229]:
topic images should be 288px wide.
Expected: 288
Actual: 595
@kenyonj Thanks, I'll add a different image now. |
Head branch was pushed to by a user without write access
@kenyonj can you merge it now :) |
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png
, square, dimensions 288x288, size <= 75 kB)index.md
)Curating a new topic or collection
https://github.com/topics/scapy
orhttps://github.com/collections/scapy
)*.png
image (if applicable) andindex.md
index.md
conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docsSomething that does not neatly fit into the binary options above
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.