Support remaining target-api-url commands (-1)
#1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianaj
changed the title
target-api-url commands
Unit Test Results805 tests 805 ✅ 22s ⏱️ Results for commit e2befc6. ♻️ This comment has been updated with latest results. |
brianaj
changed the title
target-api-url commandstarget-api-url commands (-1)
gargola
approved these changes
Feb 7, 2024
src/Octoshift/Commands/AbortMigration/AbortMigrationCommandBase.cs
Outdated
Show resolved
Hide resolved
src/Octoshift/Commands/WaitForMigration/WaitForMigrationCommandBase.cs
Outdated
Show resolved
Hide resolved
src/Octoshift/Commands/RevokeMigratorRole/RevokeMigratorRoleCommandBase.cs
Outdated
Show resolved
Hide resolved
…e.cs Co-authored-by: Arin Ghazarian <[email protected]>
…dBase.cs Co-authored-by: Arin Ghazarian <[email protected]>
…mmandBase.cs Co-authored-by: Arin Ghazarian <[email protected]>
okay I have one more PR so will update to virtual for any others missed there 👍🏾 |
ArinGhazarian
approved these changes
Feb 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of #1094 and https://github.ghe.com/github/octoshift/issues/7956
Shipping remaining commands in https://github.ghe.com/github/octoshift/issues/7956#issuecomment-8111321 except
generate-scriptas that is more involved and will ship changes in separate PR.Decided not to functional test since that is more involved and timely and we have shipped enough similar commands that unit testing should be good enough.
ThirdPartyNotices.txt(if applicable)