This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
display single select options in json format #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mntlty
commented
Apr 19, 2023
| for _, opt := range config.opts.singleSelectOptions { | ||
| opts = append(opts, githubv4.ProjectV2SingleSelectFieldOptionInput{ | ||
| Name: githubv4.String(opt), | ||
| Name: githubv4.String(opt), | ||
| Color: githubv4.ProjectV2SingleSelectFieldOptionColor("GRAY"), |
There was a problem hiding this comment.
the api requires a color, testing in the UI this is set as the default
mntlty
commented
Apr 19, 2023
| @@ -145,10 +145,11 @@ func createFieldArgs(config createFieldConfig) (*createProjectV2FieldMutation, m | |||
| } | |||
|
|
|||
| if len(config.opts.singleSelectOptions) != 0 { | |||
| opts := make([]githubv4.ProjectV2SingleSelectFieldOptionInput, len(config.opts.singleSelectOptions)) | |||
| opts := make([]githubv4.ProjectV2SingleSelectFieldOptionInput, 0) | |||
There was a problem hiding this comment.
this was sending bad data when used with append below, since this will usually be small it's simpler to stick to conventions and not initialize the length even though it's known
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--format=jsonfor fields, display the name and id for fields.Fixes a bug where create-field was sending empty data with single select options.
Set the default color for single select options to gray, as this is a required field by the API.