Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework PrestaShop.gitignore #1479

Merged
merged 1 commit into from
Apr 19, 2015
Merged

Rework PrestaShop.gitignore #1479

merged 1 commit into from
Apr 19, 2015

Conversation

julienbourdeau
Copy link
Contributor

As a PrestaShop core developer I reworked our .gitignore file last year (PrestaShop/PrestaShop@d6956eb). I realized recently that the one provided by GitHub is an old version of our file.

The file in this repo was written to maintain the core, then we ignore files that a normal user will need to track (and vice versa).

Here are some explainations about my modifications ('we' refers to the PrestaShop core team) :

  • All index.php files, except the one under the root directory, are redirections to the root folder. We used to version them because of the licence at the top of the file.
  • cache/ should be ignored completely (of course).
  • robots.txt should be versionned. As a user, you will edit it and want to keep his changes. We ignored it to keep a clean version for releases.
  • PrestaShop will generate multple sitemaps if you have multistore or multilanguage features activated. All sitemaps will be prefixed so I changed the pattern to *sitemap.xml
  • A user will want to version his modules to track his changes. Only config*.xml files needs to be ignored since they are generated if needed.

If you need more details please let me know, I'll be happy to explain.

NOTE: The previous version kept track of core files, I didn't change this behavior.

The previous file was made for PrestaShop maintainers it didn't suit PrestaShop user needs.
@arcresu
Copy link
Contributor

arcresu commented Apr 19, 2015

Thanks!

arcresu added a commit that referenced this pull request Apr 19, 2015
@arcresu arcresu merged commit 77e2983 into github:master Apr 19, 2015
@prestancedesign
Copy link
Contributor

@julienbourdeau I notice that cache/ causing problem for gitignore classes/cache/.
I create this PR #1693 to fix it.

u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants