Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npmjs docs link #1486

Merged
merged 2 commits into from
May 2, 2015
Merged

Update npmjs docs link #1486

merged 2 commits into from
May 2, 2015

Conversation

gouthamve
Copy link
Contributor

The previous link gives 404

@gouthamve
Update npmjs docs link
7fd9896 
The previous link gives 404
@arcresu
Copy link
Contributor

arcresu commented Apr 30, 2015

Thanks, but while you've fixed the link, the URL fragment has also changed. It should be this:

https://docs.npmjs.com/misc/faq#should-i-check-my-node-modules-folder-into-git

(The underscore became a dash.). If you fix that up I'll merge 🎉

@arcresu arcresu removed the needs info label May 2, 2015
@arcresu
Copy link
Contributor

arcresu commented May 2, 2015

Perfect, thanks!

arcresu added a commit that referenced this pull request May 2, 2015
@arcresu
Merge pull request #1486 from Gouthamve/patch-1
ae5f226 
Update npmjs docs link
@arcresu arcresu merged commit ae5f226 into github:master May 2, 2015
u9E9F pushed a commit to u9E9F/gitignore that referenced this pull request Jul 8, 2017
@arcresu
Merge pull request github#1486 from Gouthamve/patch-1
69491e2 
Update npmjs docs link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gouthamve @arcresu