Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gradle] build rule should support subprojects #2219

Closed
wants to merge 1 commit into from
Closed

[Gradle] build rule should support subprojects #2219

wants to merge 1 commit into from

Conversation

guilhermerigorecio
Copy link

The current form does not work with multiple subprojects.

@drothmaler
Copy link
Contributor

drothmaler commented Dec 29, 2016

Hm, but this way we would also ignore all other build folders (e.g. if one of your packages is: com.company.project.build.tools). So, I think we should at least unignore all build folders inside of src/ folders... something like:
!**src/**/build/ (not sure, if this is right)

See: #2026 for the pull request, that made the rule more specific...
And this one is also related: #2035

@shiftkey
Copy link
Member

I'm not sure whether a wildcard term will help or hinder here, as people like to organize their source code in different ways (there's already mentions of src and buildSrc).

Could we document this rule better to explain that it will only cover build at the root, and how to add additional rules to handle subproject scenarios?

@shiftkey shiftkey changed the title Update Gradle.ignore [Gradle] build rule should support subprojects Jan 29, 2017
@shiftkey
Copy link
Member

Closing this out due to inactivity

@shiftkey shiftkey closed this May 12, 2019
@Baneeishaque
Copy link

What about this? @ @ @ @shiftkey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants