Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider not using LCS by default or allow switching it off #207

Closed
nbarrientos opened this issue Feb 20, 2019 · 1 comment · Fixed by #227
Closed

Consider not using LCS by default or allow switching it off #207

nbarrientos opened this issue Feb 20, 2019 · 1 comment · Fixed by #227
Labels
enhancement help wanted

Comments

@nbarrientos
Copy link
Contributor

Hi,

Hashdiff uses LCS by default when comparing arrays. This algorithm produces a friendlier and easier to read diff for humans, but at high cost O(n2).

Would you consider a patch to either disable LCS or perhaps to allow switching it off via the command line? I'd happy to prepare it.

Thanks.
@ahayworth
Copy link
Contributor

@nbarrientos Yes, I think an option to toggle LCS (on by default) would be reasonable. I'll be happy to review such a PR! 😄

nbarrientos added a commit to cernops/octocatalog-diff that referenced this issue Sep 28, 2020
@nbarrientos
Add --[no-]use-lcs
2c754e9 
Add a CLI option (--[no-]use-lcs) so the usage of the LCS algo when
comparing arrays can be switched on and off. The default is to keep it
on as it's has been so far.

Closes github#207
@nbarrientos nbarrientos mentioned this issue Sep 28, 2020
Merged
nbarrientos added a commit to cernops/octocatalog-diff that referenced this issue Jan 13, 2021
@nbarrientos
Add --[no-]use-lcs
17bcef6 
Add a CLI option (--[no-]use-lcs) so the usage of the LCS algo when
comparing arrays can be switched on and off. The default is to keep it
on as it's has been so far.

Closes github#207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --[no-]use-lcs cernops/octocatalog-diff
2 participants
@nbarrientos @ahayworth