Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to treat an object the same as a single array containing that object #170

Merged
merged 11 commits into from
Dec 19, 2017

Conversation

kpaulisse
Copy link
Contributor

Overview

This pull request adds a filter to treat an object the same as a single array containing that object. This difference can appear between some versions of Puppet but it really doesn't reflect an actual difference.

With filter off, this is a difference:

old: { notify: "Service[foo]" }
new: { notify: [ "Service[foo]" ] }

With the filter turned on, the above example is not a difference.

Fixes #166

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.

@kpaulisse kpaulisse mentioned this pull request Dec 17, 2017
@kpaulisse kpaulisse merged commit 153cea5 into master Dec 19, 2017
@kpaulisse kpaulisse deleted the kpaulisse-filter-single-array branch December 7, 2018 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

octocatalog-test changes string to array with a single element
1 participant