Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set storeconfig_backends #312

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Conversation

ngrundy
Copy link
Contributor

@ngrundy ngrundy commented Sep 13, 2024

Overview

This pull request adds the ability to set the storeconfigs_backend option. This allows for the selection of alternate backends for storing catalog data.

The change allows the octocatalog-diff command to now accept the paramater --storeconfigs-backend [puppetdb|yaml|json] which sets the terminus for storeconfigs on the underlying puppet catalog compile command.

The default for storeconfigs_backend has been defaulted to puppetdb to maintain backwards compatibility.

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage by running rake coverage:spec or ignoring untestable sections of code with # :nocov comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added a new command line option, we would greatly appreciate a corresponding integration test that exercises it from start to finish. This is optional but recommended.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

/cc [related issues] [teams and individuals, making sure to mention why you're CC-ing them]

@ngrundy ngrundy marked this pull request as ready for review September 13, 2024 01:18
@ngrundy ngrundy changed the title Storeconfigs backend Add ability to set storeconfig_backends Sep 13, 2024
Copy link
Contributor

@cjmartian cjmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a question - not blocking. Thanks for doing this!

@jhongturney jhongturney merged commit 14e49ca into master Sep 16, 2024
11 of 12 checks passed
@jhongturney jhongturney deleted the storeconfigs-backend branch September 16, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants