Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's get octocatalog-diff to latest #11

Merged
merged 24 commits into from
Jan 23, 2024
Merged

Conversation

anth1y
Copy link
Contributor

@anth1y anth1y commented Dec 7, 2023

Overview

This pull request updates octocatalog-diffs to the latest version

Checklist

  • Make sure that all of the tests pass, and fix any that don't. Just run bundle exec rake in your checkout directory, or review the CI job triggered whenever you push to a pull request.
  • Make sure that there is 100% test coverage (the CI job will test for this). You can ignore untestable sections of code with # :nocov: comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.
  • If you have added any new gem dependencies, make sure those gems are licensed under the MIT or Apache 2.0 license. We cannot add any dependencies on gems licensed under GPL.
  • If you have added any new gem dependencies, make sure you've checked in a copy of the .gem file into the vendor/cache directory.

/cc @github/compute-foundation

@cjmartian cjmartian force-pushed the update-octocatalog-diff branch 3 times, most recently from 60c2aa3 to 8cae619 Compare January 22, 2024 21:09
@cjmartian cjmartian force-pushed the update-octocatalog-diff branch from 8cae619 to 2cd79b8 Compare January 22, 2024 21:12
@cjmartian cjmartian force-pushed the update-octocatalog-diff branch from e7b89a4 to a637695 Compare January 22, 2024 22:30
@cjmartian cjmartian force-pushed the update-octocatalog-diff branch from a637695 to 6162cc9 Compare January 22, 2024 22:33
@cjmartian cjmartian force-pushed the update-octocatalog-diff branch from d5adcd4 to cb59f94 Compare January 23, 2024 00:24
@cjmartian cjmartian force-pushed the update-octocatalog-diff branch from cb59f94 to 9d6c0b5 Compare January 23, 2024 00:31
@jhongturney
Copy link
Contributor

Good job here, a lot of minor formatting changes to work with the updated rules. I like the improvements you made in the randomization test. Thanks for getting it across the finish line 👍🏻

@cjmartian cjmartian merged commit da890f7 into main Jan 23, 2024
4 checks passed
@jhongturney jhongturney deleted the update-octocatalog-diff branch January 29, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants