-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let's get octocatalog-diff to latest #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjmartian
approved these changes
Dec 7, 2023
Add lint and test action
… into update-octocatalog-diff
Co-authored-by: Brandt Woolf <[email protected]>
cjmartian
force-pushed
the
update-octocatalog-diff
branch
3 times, most recently
from
January 22, 2024 21:09
60c2aa3
to
8cae619
Compare
cjmartian
force-pushed
the
update-octocatalog-diff
branch
from
January 22, 2024 21:12
8cae619
to
2cd79b8
Compare
cjmartian
force-pushed
the
update-octocatalog-diff
branch
from
January 22, 2024 22:30
e7b89a4
to
a637695
Compare
cjmartian
force-pushed
the
update-octocatalog-diff
branch
from
January 22, 2024 22:33
a637695
to
6162cc9
Compare
cjmartian
force-pushed
the
update-octocatalog-diff
branch
from
January 23, 2024 00:24
d5adcd4
to
cb59f94
Compare
cjmartian
force-pushed
the
update-octocatalog-diff
branch
from
January 23, 2024 00:31
cb59f94
to
9d6c0b5
Compare
Good job here, a lot of minor formatting changes to work with the updated rules. I like the improvements you made in the randomization test. Thanks for getting it across the finish line 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request updates octocatalog-diffs to the latest version
Checklist
bundle exec rake
in your checkout directory, or review the CI job triggered whenever you push to a pull request.# :nocov:
comments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests..gem
file into the vendor/cache directory./cc @github/compute-foundation