Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate TOC automatically #2551

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Generate TOC automatically #2551

merged 5 commits into from
Oct 5, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Sep 24, 2021

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Thanks to the great snippet jekyll-toc, we can automatically generate TOC for all languages (not just English). This is very convenient and saves us from having to set a TOC manually. The final result is the same as before, there are no breaking changes.

lex111 and others added 2 commits September 28, 2019 19:42
Upd

Co-authored-by: Justin Kenyon <[email protected]>
Co-authored-by: Dependabot <[email protected]>
Co-authored-by: Liu <[email protected]>
Co-authored-by: Sidak Singh Aulakh <[email protected]>
Co-authored-by: Mike McQuaid <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: Tal Safran <[email protected]>
Co-authored-by: leolleo <[email protected]>
Co-authored-by: Gabriel Rafael Gomes <[email protected]>
Co-authored-by: Samuel Jiang <[email protected]>
Co-authored-by: William Aboucaya <[email protected]>
Co-authored-by: Samuel Jiang <[email protected]>
Co-authored-by: Wang Qin <[email protected]>
Co-authored-by: null <dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Ryan <[email protected]>
@lex111 lex111 requested a review from a team as a code owner September 24, 2021 15:03
Copy link
Contributor

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Please fix the merge conflicts and can look at merging this.

@lex111
Copy link
Contributor Author

lex111 commented Oct 4, 2021

@MikeMcQuaid done ✔️

Copy link
Contributor

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work here @lex111, love the cleanup! You rock! 🎉 ❤️

@MikeMcQuaid MikeMcQuaid merged commit f2e8fca into github:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants