fix grammatical and punctuation errors on CONTRIBUTING.md file #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smashwilson
reviewed
Mar 7, 2022
CONTRIBUTING.md
Outdated
Comment on lines
35
to
36
| * Please ensure that your contribution passes all tests if you open a pull request. If there are test failures, you will need to address them before merging your contribution. | ||
| * When adding content, please consider if it is widely valuable. Please don't add references or links to things you or your employer have created, as others will do if they appreciate it. |
There was a problem hiding this comment.
Suggested change
| * Please ensure that your contribution passes all tests if you open a pull request. If there are test failures, you will need to address them before merging your contribution. | |
| * When adding content, please consider if it is widely valuable. Please don't add references or links to things you or your employer have created, as others will do if they appreciate it. | |
| * Please ensure that your contribution passes all tests if you open a pull request. If there are test failures, you will need to address them before we can merge your contribution. | |
| * When adding content, please consider if it is widely valuable. Please don't add references or links to things you or your employer have created, as others will do so if they appreciate it. |
I'm on board with most of the rephrasing but:
- Contributors don't have permission to merge their own contributions, so changing "we can merge" to "merging" doesn't make sense; and
- I think the second line still reads better with the "so" in place (but adding the comma is 👍🏻 )
There was a problem hiding this comment.
All right that's OK.
Hossein13M
commented
Mar 7, 2022
CONTRIBUTING.md
Outdated
Comment on lines
35
to
36
| * Please ensure that your contribution passes all tests if you open a pull request. If there are test failures, you will need to address them before merging your contribution. | ||
| * When adding content, please consider if it is widely valuable. Please don't add references or links to things you or your employer have created, as others will do if they appreciate it. |
There was a problem hiding this comment.
All right that's OK.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
The following Pull request, fix some grammatical issues and add punctuation to improve the readability of the
CONTRIBUTING.mdfile.