Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Ruby 2.3.0 or greater #575

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Require Ruby 2.3.0 or greater #575

merged 2 commits into from
Jul 2, 2018

Conversation

parkr
Copy link
Contributor

@parkr parkr commented Jun 29, 2018

I noticed in https://github.com/github/pages/pull/2086 that jekyll-seo-tag v2.5.0 requires Ruby 2.3 or greater.

As it turns out, Ruby 2.2 is now EOL, and Ruby 2.3 is EOL in March 2019. https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/

In the Jekyll project, it was our general understanding that we would drop support for a minor bump of Ruby only explicitly (i.e. require something higher) in a major version bump of Jekyll. In GitHub Pages, we don't have that same issue, since every version bump is a major version bump.

Generally speaking, supporting an EOL Ruby version is ill-advised. An EOL version doesn't receive security patches, and may have bugs that will never be fixed. By targeting Ruby 2.3 or higher, we can eliminate the likelihood that our users are exposed to any security vulnerabilities that are discovered in Ruby 2.2 and earlier.

Ruby version constraints are heavy-handed, but upgrading is key to keeping our community safe and progressing.

@parkr parkr requested a review from benbalter June 29, 2018 17:33
Copy link
Contributor

@benbalter benbalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, and looks like OS X Mojave ships with 2.3, which was my concern, so 👍

@parkr parkr merged commit 0d93f62 into master Jul 2, 2018
@parkr parkr deleted the ruby-2-2-eol branch July 2, 2018 15:49
@kenman345
Copy link
Contributor

It appears listen and activesupport were pinned because they had lots of errors with Ruby 2.1 but if we are bumping minimum support for this gem to be Ruby 2.3 then shouldnt we be able to safely bump up those version number too? (and remove the comments about being pinned)?

Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants