Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes round to string unit #253

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

zbinlin
Copy link
Contributor

@zbinlin zbinlin commented Mar 4, 2023

Fixes round to single unit function returns nows when durations exceeds -27 days in the same month.

Fixes round to single unit function returns `nows` when durations exceeds -27 days in the same month.
@zbinlin zbinlin requested a review from a team as a code owner March 4, 2023 16:03
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks so much!

@keithamus keithamus merged commit f0f5e08 into github:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants