Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ua sniffing for support #179

Merged
merged 8 commits into from
Oct 7, 2015
Merged

Ua sniffing for support #179

merged 8 commits into from
Oct 7, 2015

Conversation

oreoshake
Copy link
Contributor

Integrating the browser sniffing / directive use that GitHub uses internally. Use the UA to determine which directives should be supported. Provides better validation of config values.


DIRECTIVES_2_0 = [
DIRECTIVES_1_0,
:base_url,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely, thanks for the 👀

oreoshake added a commit that referenced this pull request Oct 7, 2015
@oreoshake oreoshake merged commit 7efa486 into master Oct 7, 2015
@oreoshake oreoshake deleted the ua-sniffing-for-support branch October 7, 2015 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants