Secure Cookies #231
Merged
Secure Cookies #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll drop 1.9.3 in the next major release, but for now please make travis happy. |
| end | ||
|
|
||
| def config(req) | ||
| req.env[SECURE_HEADERS_CONFIG] || Configuration.get(Configuration::DEFAULT_CONFIG) |
There was a problem hiding this comment.
@oreoshake is there an easier way to access the config from this context?
There was a problem hiding this comment.
req.env[SECURE_HEADERS_CONFIG] should suffice.
There was a problem hiding this comment.
Or maybe make config_for public? https://github.com/twitter/secureheaders/blob/44c8c3edfe6c5456274c448ba68371b20fe649d7/lib/secure_headers.rb#L225
There was a problem hiding this comment.
Sounds good to me, will help keep things dry
different contexts.
|
Woot. I'll release this with #232 tomorrow. |
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #145 for initial discussion
We would like to give users the ability to flag all cookies as secure: https://www.owasp.org/index.php/SecureFlag