Alternative fix for already initialized constant #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Kohn <[email protected]>
|
You didn't need a new pull request for this one :P I would have been happy with just another (even squashed) commit on the other branch. No issues here though 👍 LGTM. |
|
I just thought I'd show both options for clarity. These values are never falsey, so the conditional assignment works equivalently here. But, I'm always happy to have the opportunity to learn things, in this case from this excellent blog post: http://www.rubyinside.com/what-rubys-double-pipe-or-equals-really-does-5488.html Thanks for your review. |
|
Does moving the definitions inside of the |
|
@oreoshake I just checked and moving the constant within the namespace block dankohn@4bc4012 still results in: $ rake test
/Users/dan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/secureheaders-4bc4012e8e5b/lib/tasks/tasks.rake:4: warning: already initialized constant INLINE_SCRIPT_REGEX
/Users/dan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/secureheaders-4bc4012e8e5b/lib/tasks/tasks.rake:4: warning: previous definition of INLINE_SCRIPT_REGEX was here
/Users/dan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/secureheaders-4bc4012e8e5b/lib/tasks/tasks.rake:5: warning: already initialized constant INLINE_STYLE_REGEX
/Users/dan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/secureheaders-4bc4012e8e5b/lib/tasks/tasks.rake:5: warning: previous definition of INLINE_STYLE_REGEX was here
/Users/dan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/secureheaders-4bc4012e8e5b/lib/tasks/tasks.rake:6: warning: already initialized constant INLINE_HASH_SCRIPT_HELPER_REGEX
/Users/dan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/secureheaders-4bc4012e8e5b/lib/tasks/tasks.rake:6: warning: previous definition of INLINE_HASH_SCRIPT_HELPER_REGEX was here
/Users/dan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/secureheaders-4bc4012e8e5b/lib/tasks/tasks.rake:7: warning: already initialized constant INLINE_HASH_STYLE_HELPER_REGEX
/Users/dan/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/secureheaders-4bc4012e8e5b/lib/tasks/tasks.rake:7: warning: previous definition of INLINE_HASH_STYLE_HELPER_REGEX was here
Run options: --seed 42631
# Running:So, please consider accepting this PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Kohn [email protected]
This is an alternative fix to #258. It also resolves #257 and addresses the comment #258 (comment) by @jacobbednarz.