Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support patterns in EXEMPT_REPOS #68

Merged
merged 2 commits into from
Nov 15, 2023
Merged

support patterns in EXEMPT_REPOS #68

merged 2 commits into from
Nov 15, 2023

Conversation

tal66
Copy link
Contributor

@tal66 tal66 commented Nov 9, 2023

hi, this closes #67.
used fnmatch (unix shell-style wildcards) for simplicity.

@tal66 tal66 requested a review from zkoppert as a code owner November 9, 2023 22:28
@zkoppert
Copy link
Member

Thanks for submitting @tal66 ! I'll take a look at these changes now.

zkoppert
zkoppert approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added one test case for the no exemption list situation. Thanks for contributing!

@zkoppert zkoppert added the enhancement New feature or request label Nov 15, 2023
@zkoppert zkoppert merged commit ea4eeb1 into github:main Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert zkoppert approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EXEMPT_REPOS with a regexp
2 participants
@tal66 @zkoppert