Added TypeScript type definitions and various updates

[jef]

Description

Closes #7.

Took a stab at adding TypeScript type definitions with type definition tests.

Also includes:

• GitHub Actions workflow for tests.
• .nvmrc for those who use nvm.
• Added semicolons. This can be removed or we can add some sort of style guide.

I'm not very partial to the other changes, but could be worth investing into.

[lgarron]

Taking over for @mastahyeti. :-D

LGTM with some nits.

Added semicolons. This can be removed or we can add some sort of style guide.
Would it make sense to run this through the same linter we use for the main GitHub repo?

[lgarron]

@github/web-systems-reviewers Any concerns about merging this?

[keithamus]

This looks like a good start. Happy to see this merged from a @github/web-systems perspective 👍

[jef]

Okay, I think this is ready now. Let me know if you think we should add or change anything else!

[jef]

Would it be worth it to convert the JavaScript to TypeScript or are the typings enough?

[keithamus]

I'd be keen to see this converted to TypeScript, this might be good as a follow up PR - let's get this merged first. @lgarron do you have merge capabilities? It might be useful to have @github/web-systems adopt this repo.

[ptoomey3]

@lgarron - Can you re-approve and help get this pushed over the finish line if it is ready to merge? We should be able to test this pretty easily in prod/lab/etc by adding a new actions secret and verifying it is readable when run.

[lgarron]

@lgarron - Can you re-approve and help get this pushed over the finish line if it is ready to merge? We should be able to test this pretty easily in prod/lab/etc by adding a new actions secret and verifying it is readable when run.

I actually need to ping @mastahyeti to see if he is willing to transfer the npm registration to us, which I've been putting off. :-P

Alternatively, we could fork into @github/tweetsodium. @keithamus, would that be preferable?

[keithamus]

As the library already exists unprefixed on npm, we should continue publishing to that name. Let's wait for @mastahyeti to transfer ownership of the npm module to us.

[lgarron]

As the library already exists unprefixed on npm, we should continue publishing to that name. Let's wait for @mastahyeti to transfer ownership of the npm module to us.

For the record, I emailed him but haven't heard back yet! Will wait a while before I ping him.

[lgarron]

As the library already exists unprefixed on npm, we should continue publishing to that name. Let's wait for @mastahyeti to transfer ownership of the npm module to us.

For the record, I emailed him but haven't heard back yet! Will wait a while before I ping him.

I haven't heard back from Ben. Should we perhaps go ahead with a fork?

[ptoomey3]

I haven't heard back from Ben. Should we perhaps go ahead with a fork?

Let's try one more reach-out to Ben and then decide a week or two after.

[btoews]

👋 I responded to @lgarron a few weeks ago. I added him to the NPM package and removed myself.

[btoews]

Looks like Gmail replied from a different email address than I had received the email from. Maybe that caused it to go to spam or something.

[lgarron]

👋 I responded to @lgarron a few weeks ago. I added him to the NPM package and removed myself.

Thanks!

I do have access, I just need to add all the other JS folks who should have access before I update!

[lgarron]

I've published this as 0.0.5:
https://www.npmjs.com/package/tweetsodium
https://github.com/github/tweetsodium/releases/tag/0.0.5

[jef]

yahoo! thanks everyone for keeping this alive!

[JakeChampion]

Hi, I just noticed that the dist/index.esm.js code in 0.0.5 is using commonjs format and not esm format, is that to be expected with this change?

dist/index.esm.js code in 0.0.5 via unpkg