Fix monitoring mixin and dashboards #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dashboard is currently in JSON and has test data.
Also fixed whitespace causing mixin linting to fail.
Previously, only the repo label was added to the pull request metric. Multiple repositories can have the same repo value - the user label is required to uniquely identify a GitHub repository.
Created a GitHub repository dashboard, which graphs exporter metrics for a given repository. Also created an API usage dashboard to check the if the exporter is running out of requests. The dashboards use Grafonnet, a library for writing Grafana dashboards. Added jsonnet-bundler integration so the Grafonnet package can be fetched.
jb install has to be run before linting as the linter checks the dependency files exist.
Added dashboard descriptions to README and updated running instructions so Jsonnet libraries that are required by the build are installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes, and supercedes #64, which also included the same change as #65.
The addition in this PR over both of those previous PRs is that the monitoring dashboard now properly uses whichever Grafana datasource that is selected by the user, rather than using the global default.