fix: page layouts (#1766)

* fix: page layouts Signed-off-by: Adam Setch <[email protected]> * fix: page layouts Signed-off-by: Adam Setch <[email protected]> --------- Signed-off-by: Adam Setch <[email protected]>
gitify-app · Jan 23, 2025 · 625cb27 · 625cb27
1 parent cd83ed9
commit 625cb27
Show file tree

Hide file tree

Showing 15 changed files with 43 additions and 34 deletions.
diff --git a/src/renderer/App.tsx b/src/renderer/App.tsx
@@ -47,7 +47,7 @@ export const App = () => {
       <BaseStyles>
         <AppProvider>
           <Router>
-            <div className="flex h-full overflow-x-hidden overflow-y-auto flex-col pl-10 bg-gitify-background">
+            <div className="flex h-screen overflow-x-hidden overflow-y-auto flex-col pl-10 bg-gitify-background">
               <Loading />
               <Sidebar />
               <Routes>

diff --git a/src/renderer/components/Oops.test.tsx b/src/renderer/components/Oops.test.tsx
@@ -1,7 +1,12 @@
 import { render } from '@testing-library/react';
+import { ensureStableEmojis } from '../__mocks__/utils';
 import { Oops } from './Oops';
 
 describe('renderer/components/Oops.tsx', () => {
+  beforeEach(() => {
+    ensureStableEmojis();
+  });
+
   it('should render itself & its children - specified error', () => {
     const mockError = {
       title: 'Error title',

diff --git a/src/renderer/components/__snapshots__/AllRead.test.tsx.snap b/src/renderer/components/__snapshots__/AllRead.test.tsx.snap
diff --git a/src/renderer/components/__snapshots__/Oops.test.tsx.snap b/src/renderer/components/__snapshots__/Oops.test.tsx.snap
diff --git a/src/renderer/components/layout/Centered.tsx b/src/renderer/components/layout/Centered.tsx
@@ -16,7 +16,7 @@ export const Centered: FC<ICentered> = ({
       align="center"
       justify="center"
       padding="spacious"
-      className={fullHeight && 'min-h-screen'}
+      className={fullHeight && 'h-full'}
     >
       {props.children}
     </Stack>

diff --git a/src/renderer/components/layout/Page.tsx b/src/renderer/components/layout/Page.tsx
@@ -7,7 +7,7 @@ interface IPage {
 
 export const Page: FC<IPage> = (props: IPage) => {
   return (
-    <div className="flex flex-col h-screen" data-testid={props.id}>
+    <div className="flex flex-col h-full" data-testid={props.id}>
       {props.children}
     </div>
   );

diff --git a/src/renderer/components/layout/__snapshots__/Centered.test.tsx.snap b/src/renderer/components/layout/__snapshots__/Centered.test.tsx.snap
diff --git a/src/renderer/components/layout/__snapshots__/EmojiSplash.test.tsx.snap b/src/renderer/components/layout/__snapshots__/EmojiSplash.test.tsx.snap
diff --git a/src/renderer/components/layout/__snapshots__/Page.test.tsx.snap b/src/renderer/components/layout/__snapshots__/Page.test.tsx.snap
diff --git a/src/renderer/routes/LoginWithOAuthApp.tsx b/src/renderer/routes/LoginWithOAuthApp.tsx
@@ -67,7 +67,7 @@ export const LoginWithOAuthAppRoute: FC = () => {
 
     return (
       <Page id="Login With OAuth App">
-        <form onSubmit={handleSubmit}>
+        <form onSubmit={handleSubmit} className="-mt-5">
           <FieldInput
             name="hostname"
             label="Hostname"

diff --git a/src/renderer/routes/__snapshots__/Filters.test.tsx.snap b/src/renderer/routes/__snapshots__/Filters.test.tsx.snap
diff --git a/src/renderer/routes/__snapshots__/Login.test.tsx.snap b/src/renderer/routes/__snapshots__/Login.test.tsx.snap
diff --git a/src/renderer/routes/__snapshots__/LoginWithOAuthApp.test.tsx.snap b/src/renderer/routes/__snapshots__/LoginWithOAuthApp.test.tsx.snap
diff --git a/src/renderer/routes/__snapshots__/LoginWithPersonalAccessToken.test.tsx.snap b/src/renderer/routes/__snapshots__/LoginWithPersonalAccessToken.test.tsx.snap
diff --git a/src/renderer/routes/__snapshots__/Settings.test.tsx.snap b/src/renderer/routes/__snapshots__/Settings.test.tsx.snap