-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: gitify logo icon #1275
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c49db7a
refactor: logo icon
setchy 7999552
refactor: logo icon
setchy 41186be
Merge branch 'main' into refactor/logo-icon
afonsojramos 0d32c3f
use size
setchy 12742e4
chore: add `size` prop to LogoIcon
afonsojramos 8e13b34
Merge branch 'main' into refactor/logo-icon
afonsojramos 31b160f
Merge branch 'main' into refactor/logo-icon
afonsojramos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
src/components/__snapshots__/AccountNotifications.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import { fireEvent, render, screen } from '@testing-library/react'; | ||
import { LogoIcon } from './LogoIcon'; | ||
|
||
describe('components/icons/LogoIcon.tsx', () => { | ||
it('renders correctly (light)', () => { | ||
const tree = render(<LogoIcon />); | ||
|
||
expect(tree).toMatchSnapshot(); | ||
}); | ||
|
||
it('renders correctly (dark)', () => { | ||
const tree = render(<LogoIcon isDark />); | ||
|
||
expect(tree).toMatchSnapshot(); | ||
}); | ||
|
||
it('should click on the logo', () => { | ||
const onClick = jest.fn(); | ||
render(<LogoIcon onClick={onClick} size="small" />); | ||
|
||
fireEvent.click(screen.getByLabelText('Gitify Logo')); | ||
|
||
expect(onClick).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('should render a different size', () => { | ||
const tree = render(<LogoIcon size="large" />); | ||
|
||
expect(tree).toMatchSnapshot(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm new to this clsx package
What's your thoughts on
size === 'small' && 'size-5', size === 'medium' && 'size-10', size === 'large' && 'size-16'