feat: use platform version for github enterprise server feature availability (mark as done) #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
…ature availability
setchy
changed the title
…ature availability
…app/gitify into feat/mark-as-done-server
|
As requested, I tested this branch locally: it works perfectly! |
Awesome, really appreciate the feedback @julienperrault. We'll get this merged and released shortly |
bmulholland
reviewed
Aug 5, 2024
| @@ -46,6 +46,7 @@ export type Status = 'loading' | 'success' | 'error'; | |||
| export interface Account { | |||
| method: AuthMethod; | |||
| platform: PlatformType; | |||
| version?: string; | |||
There was a problem hiding this comment.
Maybe we should comment this explaining what it is?
bmulholland
approved these changes
Aug 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #1423
Per the API Docs,
Mark as Donenot supported in GitHub Enterprise Server 2.12 or older.This PR fetches the GitHub Enterprise Server version on start and uses this to determine "Mark as Done" feature availability.
Closes #1412