feat: detailed error handling #965
Conversation
| pnpm test -- --onlyChanged |
There was a problem hiding this comment.
And back again? Permissions too.
Either way is fine, but probably best to keep it stable
There was a problem hiding this comment.
Super odd. I think I've finally got to the root of my husky dramas. NVM has been meddling with it
| ).data; | ||
| return response.html_url; | ||
| } catch (err) { | ||
| console.error('Failed to get html url'); |
There was a problem hiding this comment.
Confirming this is intentionally still there?
There was a problem hiding this comment.
I see 👀
You are planning on having a central place where you define all error messages aren't you? 👀
There was a problem hiding this comment.
Do you guys want me to remove the try/catch from subject/helper apiRequestAuth calls?
| }, | ||
| }; | ||
| } catch (err) { | ||
| console.error('Pull Request subject retrieval failed'); |
| (response as IssueComments)?.user ?? (response as ReleaseComments).author | ||
| ); | ||
| } catch (err) { | ||
| console.error('Discussion latest comment retrieval failed'); |
thanks! I think if/when we support partial notifications (ie: one account works, one account fails) the Error page will need to morph into an Error/Warning banner. A future bridge for us to cross |
|
Ended up renaming the component back to |
Improve error handling feedback loop by inspecting err.response and determining root cause of error.
Refactored the previous
Oopsview to allow error types to be passed in.