Do not fail when the group member does not exist #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ilpianista
force-pushed
the
bugfix/gitlab-group-member-not-exists
branch
2 times, most recently
from
c63efce to
17aa259
Compare
matt-demers
referenced
this pull request
in appian/terraform-provider-gitlab
Apr 20, 2020
This change was taken from an open PR on the upstream provider. See https://github.com/terraform-providers/terraform-provider-gitlab/pull/267
matt-demers
referenced
this pull request
in appian/terraform-provider-gitlab
Apr 20, 2020
This change was based on an open PR to the upstream provider. See https://github.com/terraform-providers/terraform-provider-gitlab/pull/267 If that change merges, we should duplicate its functionality in the project_membership resource, and submit a pull request.
matt-demers
referenced
this pull request
in appian/terraform-provider-gitlab
May 11, 2020
This change was taken from an open PR on the upstream provider. See https://github.com/terraform-providers/terraform-provider-gitlab/pull/267
matt-demers
referenced
this pull request
in appian/terraform-provider-gitlab
May 11, 2020
This change was based on an open PR to the upstream provider. See https://github.com/terraform-providers/terraform-provider-gitlab/pull/267 If that change merges, we should duplicate its functionality in the project_membership resource, and submit a pull request.
valdisrigdon
referenced
this pull request
in appian/terraform-provider-gitlab
Jun 11, 2020
This change was taken from an open PR on the upstream provider. See https://github.com/terraform-providers/terraform-provider-gitlab/pull/267
valdisrigdon
referenced
this pull request
in appian/terraform-provider-gitlab
Jun 11, 2020
This change was based on an open PR to the upstream provider. See https://github.com/terraform-providers/terraform-provider-gitlab/pull/267 If that change merges, we should duplicate its functionality in the project_membership resource, and submit a pull request.
ilpianista
force-pushed
the
bugfix/gitlab-group-member-not-exists
branch
from
17aa259 to
3f78b68
Compare
ilpianista
force-pushed
the
bugfix/gitlab-group-member-not-exists
branch
from
3f78b68 to
f2f4186
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as discussed in #240: if the group member doesn't exist, then remove it from the state also.
Fixes #254