Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail when project member does not exist #473

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

valdisrigdon
Copy link
Contributor

Similar to #267

This change was based on an open PR to the upstream provider.
See https://github.com/terraform-providers/terraform-provider-gitlab/pull/267

If that change merges, we should duplicate its functionality in the
project_membership resource, and submit a pull request.
@valdisrigdon
Copy link
Contributor Author

@armsnyder Any chance this can get reviewed?

Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. This is also implemented in #318.

@armsnyder armsnyder merged commit dce2bac into gitlabhq:master Nov 23, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants