Added external Wiki service

[Shocktrooper]

Resolves #996

[armsnyder]

Thanks. Just found a test bug.

[armsnyder]

lgtm!

[armsnyder]

Test failed

Error running post-test destroy, there may be dangling resources: [ERROR] External Wiki Service 89 still exists

[Shocktrooper]

@armsnyder I wonder if this is the downstream API as looking at the code nothing is apparent. I will check the GitLab API and see what it returns after some testing.
I found this in the docs
https://docs.gitlab.com/ee/api/integrations.html#:~:text=Disable%20the%20External%20wiki%20integration%20for%20a%20project.%20Integration%20settings%20are%20preserved.

[Shocktrooper]

Yup it appears there is an active flag that is set to false on delete. I will refactor the resource to include this computed field

[Shocktrooper]

@armsnyder After looking at the other integrations code I believe most if not all of them need to have their resource + unit tests updated to include the active flag + some computed fields. The unit tests for destruction verification seem to rely on the project being marked for deletion vs the integration being deactivated on top of a 404 being impossible to get after an integration is activated the first time.

[armsnyder]

Thanks for updating the code to match the other services. There's a new test failure now:

resource_gitlab_service_external_wiki_test.go:24: Step 3/6 error: Check failed: Check 4/4 error: gitlab_service_external_wiki.this: Attribute 'updated_at' expected "2022-04-02T05:12:58Z", got "2022-04-02T05:13:01Z"
[277](https://github.com/gitlabhq/terraform-provider-gitlab/runs/5797570330?check_suite_focus=true#step:8:277)

It looks like in the test you are comparing CreatedAt and UpdatedAt

testCheckResourceAttrLazy(externalWikiResourceName, "updated_at", func() string { return externalWikiService.CreatedAt.Format(time.RFC3339) }),

[armsnyder]

lgtm thanks!

[github-actions]

This functionality has been released in v3.14.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!