Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/gitlab_project_protected_environment: Allow multiple deploy_access_levels #1004

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

armsnyder
Copy link
Collaborator

Description

Closes #1000

The functional change is simply the removal of the MaxItems: 1 field from the schema.

I decided to rewrite the tests because of how they were organized by access level type. To reduce duplication with my new test case, it made the most sense to combine them into a single test.

PR Checklist Acknowledgement

  • I acknowledge that all of the following items are true, where applicable:
    • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
    • Examples are updated with:
      • A *.tf file for the resource/s with at least one usage example
      • A *.sh file for the resource/s with an import example (if applicable)
    • New resources have at minimum a basic test with three steps:
      • Create the resource
      • Update the attributes
      • Import the resource
    • No new //lintignore comments were copied from existing code. (Linter rules are meant to be enforced on new code.)

@armsnyder armsnyder force-pushed the protected-environment-multi branch from a2572b3 to 30ae70c Compare April 3, 2022 02:15
@armsnyder armsnyder merged commit 695bc84 into gitlabhq:main Apr 3, 2022
@armsnyder armsnyder added this to the v3.14.0 milestone Apr 3, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022

This functionality has been released in v3.14.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants