-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide gitlab_pages_domain
resource
#1026
Conversation
I expect the tests to fail for now. I run into two issues with the tests:
The latter led to xanzy/go-gitlab#1452 Why was there a different error in GitPod? Are GitLab pages enabled in GitPod? |
Hey @nagyv , yeah, pages isn't configured in the docker-compose/makefile yet. We could potentially add a new wildcard cert to the ones generated by openssl (should probably wait until we merge #1023 so we can build on top of the work shock is doing), which seems to be a pre-req for enabling pages based on: https://docs.gitlab.com/ee/administration/pages/index.html#configuration |
This pull request has merge conflicts. Please rebase your branch onto |
Conflicts are resolved. Thank you! 😀 |
Conflicts are resolved. Thank you! 😀 |
Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist. |
Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist. |
Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist. |
Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the To help this pull request get reviewed, please check that it is rebased onto the latest and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist. |
Marking this pull request as stale due to 30 days of inactivity. If this pull request receives no comments in the next 14 days it will be closed. Maintainers can also remove the To help this pull request get reviewed, please check that it is rebased onto the latest main and is passing automated checks. It also helps if you could reference an issue that the pull request resolves, and create one if it doesn't exist. |
Description
Create a
gitlab_pages_domain
resourceCloses #498
Blocked by xanzy/go-gitlab#1452
PR Checklist Acknowledgement
//lintignore
comments were copied from existing code. (Linter rules are meant to be enforced on new code.) ✅