-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gitlab_runner Resource #1049
Add gitlab_runner Resource #1049
Conversation
unfortunately, there are a couple new |
@armsnyder | @timofurrer - This is ready for review/merger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PatrickRice-KSC looks pretty solid already, thanks!
There are a few copy & paste mistakes, nitpicks / styling stuff and other minor things.
Regarding the GetOkExists()
- that's not a problem at all - IMHO it's still the best option we have with the current SDK and there will be a replacement before they delete it, thus all good.
Back to you 🏓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good work @PatrickRice-KSC once again!
LGTM 🎉
This functionality has been released in v3.15.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Description
This PR adds support for registering runners using a
gitlab_runner
resource.Closes #49
PR Checklist Acknowledgement
//lintignore
comments were copied from existing code. (Linter rules are meant to be enforced on new code.)